-
Notifications
You must be signed in to change notification settings - Fork 765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[20819] Make TimedEvent private #4727
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EduPonz
force-pushed
the
3.0.x-devel
branch
2 times, most recently
from
May 13, 2024 09:26
08ee62b
to
623db82
Compare
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
elianalf
force-pushed
the
feature/make_timedevent_private
branch
from
May 21, 2024 14:27
f0686af
to
7b540c1
Compare
@richiprosima test linux |
JesusPoderoso
requested review from
JesusPoderoso
and removed request for
JesusPoderoso
May 21, 2024 14:37
JesusPoderoso
approved these changes
May 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with green CI
@richiprosima please test_3 this |
@richiprosima test windows |
elianalf
added
the
ready-to-merge
Ready to be merged. CI and changes have been reviewed and approved.
label
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ci-pending
PR which CI is running
ready-to-merge
Ready to be merged. CI and changes have been reviewed and approved.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes TimedEvent.h private
Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist